bakaid commented on a change in pull request #709: MINIFICPP-1088 - clean up
minifiexe and MINIFI_HOME logic
URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367335301
##########
File path: libminifi/CMakeLists.txt
##########
@@ -91,10 +91,38 @@ endif()
file(GLOB SOURCES "src/utils/file/*.cpp" "src/sitetosite/*.cpp"
"src/core/logging/*.cpp" "src/core/state/*.cpp" "src/core/state/nodes/*.cpp"
"src/c2/protocols/*.cpp" "src/c2/triggers/*.cpp" "src/c2/*.cpp" "src/io/*.cpp"
${SOCKET_SOURCES} ${TLS_SOURCES} "src/core/controller/*.cpp"
"src/controllers/*.cpp" "src/core/*.cpp" "src/core/repository/*.cpp"
"src/core/yaml/*.cpp" "src/core/reporting/*.cpp" "src/provenance/*.cpp"
"src/utils/*.cpp" "src/*.cpp")
+if(WIN32)
+ if(CMAKE_SIZEOF_VOID_P EQUAL 8)
+ set(MC_COMPILER_SEARCH_PATH "$ENV{WindowsSdkVerBinPath}\\x64")
+ elseif(CMAKE_SIZEOF_VOID_P EQUAL 4)
+ set(MC_COMPILER_SEARCH_PATH "$ENV{WindowsSdkVerBinPath}\\x86")
Review comment:
The `mc.exe` to use depends on the target, not the host. CMAKE_SIZEOF_VOID_P
is defined for the target architecture, so we are in the clear.
AppVeyor builds fail to find the mc.exe though, so I have to tweak this a
little bit. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
