szaszm commented on a change in pull request #712: MINIFICPP-1047 Add property
"Drop empty flow files" to PublishKafka
URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r368584995
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -639,6 +647,17 @@ void PublishKafka::onTrigger(const
std::shared_ptr<core::ProcessContext> &contex
PublishKafka::ReadCallback callback(max_flow_seg_size, kafkaKey,
thisTopic->getTopic(), conn->getConnection(), flowFile,
attributeNameRegex, messages,
flow_file_index);
session->read(flowFile, &callback);
+
+ bool dropEmptyFlowFiles;
+ if (!callback.called_ &&
context->getProperty(DropEmptyFlowFiles.getName(), dropEmptyFlowFiles) &&
!dropEmptyFlowFiles) {
Review comment:
I think the callback is the right place for producing the kafka message,
since this is normally done in response to a successful read operation, as the
next step of the pipeline.
I'm not sure that the workaround belongs to the callback, but since there's
a lot of shared code, I think it's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
