arpadboda commented on a change in pull request #712: MINIFICPP-1047 Add
property "Drop empty flow files" to PublishKafka
URL: https://github.com/apache/nifi-minifi-cpp/pull/712#discussion_r369638075
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -99,6 +99,13 @@ core::Property PublishKafka::MessageKeyField("Message Key
Field", "The name of a
"");
core::Property PublishKafka::DebugContexts("Debug contexts", "A
comma-separated list of debug contexts to enable."
"Including: generic, broker, topic,
metadata, feature, queue, msg, protocol, cgrp, security, fetch, interceptor,
plugin, consumer, admin, eos, all", "");
+const core::Property PublishKafka::FailEmptyFlowFiles(
+ core::PropertyBuilder::createProperty("Fail empty flow files")
+ ->withDescription("Keep backwards compatibility with <=0.7.0 bug which
caused flow files with empty content to not be published to Kafka and forwarded
to failure. The old behavior is "
+ "deprecated. Use connections to drop empty flow
files!")
+ ->isRequired(false)
Review comment:
In our perspective, it does, as whenever we get the value, there is a valid
value.
Required would force the user to specify something, in this case it doesn't
apply, so it ensures backward compatibility as you highlighted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
