nghiaxlee commented on a change in pull request #710: MINIFICPP - 1110,1111 - PublishKafka, OPC processors should config and URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r369668522
########## File path: extensions/librdkafka/tests/CMakeLists.txt ########## @@ -0,0 +1,43 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +file(GLOB KAFKA_TESTS "*.cpp") + +SET(KAFKA_TEST_COUNT 0) + +FOREACH(testfile ${KAFKA_TESTS}) + get_filename_component(testfilename "${testfile}" NAME_WE) + add_executable("${testfilename}" "${testfile}") + target_include_directories(${testfilename} PRIVATE BEFORE "${CMAKE_SOURCE_DIR}/extensions/librdkafka/") + target_include_directories(${testfilename} PRIVATE BEFORE "${CMAKE_SOURCE_DIR}/extensions/standard-processors") + target_wholearchive_library(${testfilename} minifi-rdkafka-extensions) + target_wholearchive_library(${testfilename} minifi-standard-processors) + createTests("${testfilename}") + MATH(EXPR KAFKA_TEST_COUNT "${KAFKA_TEST_COUNT}+1") + if (${testfilename} MATCHES "(.)*OnSchedule(.)*") Review comment: Just a workaround for myself, I have some unit tests which require local Kafka server but never commit them. Should I add them in or modify this file for this test only? (will rewrite anyway because that line looks weird) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
