szaszm commented on a change in pull request #721: MINIFICPP-1135 - Add a
watchdog to schedulingAgent to warn in case of…
URL: https://github.com/apache/nifi-minifi-cpp/pull/721#discussion_r373061647
##########
File path: libminifi/include/SchedulingAgent.h
##########
@@ -190,8 +201,28 @@ class SchedulingAgent {
std::shared_ptr<core::controller::ControllerServiceProvider>
controller_service_provider_;
private:
+ struct SchedulingInfo {
+ std::chrono::time_point<std::chrono::steady_clock> start_time_;
+ std::string name_;
+ std::string uuid_;
+
+ SchedulingInfo(const std::shared_ptr<core::Processor> &processor) {
Review comment:
Please mark single parameter contructors `explicit` unless implicit
conversion is intended! (And if it's intended, write a comment describing why!)
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c46-by-default-declare-single-argument-constructors-explicit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
