arpadboda commented on a change in pull request #721: MINIFICPP-1135 - Add a watchdog to schedulingAgent to warn in case of… URL: https://github.com/apache/nifi-minifi-cpp/pull/721#discussion_r374057815
########## File path: libminifi/src/Configure.cpp ########## @@ -28,6 +28,7 @@ const char *Configure::nifi_flow_configuration_file = "nifi.flow.configuration.f const char *Configure::nifi_flow_configuration_file_exit_failure = "nifi.flow.configuration.file.exit.onfailure"; const char *Configure::nifi_flow_configuration_file_backup_update = "nifi.flow.configuration.backup.on.update"; const char *Configure::nifi_flow_engine_threads = "nifi.flow.engine.threads"; +const char *Configure::nifi_flow_engine_alert_time = "nifi.flow.engine.alert.time"; Review comment: We could, but none of our current settings contain unit in the name, so I would go for being consistent with what we have. In the longer term I would like to have a documentation that lists all the config params we have with units, description, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
