arpadboda commented on a change in pull request #716: MINIFICPP-1127 -
Provenance repo performance should be improved
URL: https://github.com/apache/nifi-minifi-cpp/pull/716#discussion_r374664868
##########
File path: extensions/rocksdb-repos/ProvenanceRepository.cpp
##########
@@ -17,72 +17,31 @@
*/
#include "ProvenanceRepository.h"
-#include "rocksdb/write_batch.h"
#include <string>
-#include <vector>
-#include "rocksdb/options.h"
-#include "provenance/Provenance.h"
namespace org {
namespace apache {
namespace nifi {
namespace minifi {
namespace provenance {
-void ProvenanceRepository::flush() {
- rocksdb::WriteBatch batch;
- std::string key;
- std::string value;
- rocksdb::ReadOptions options;
- uint64_t decrement_total = 0;
- while (keys_to_delete.size_approx() > 0) {
- if (keys_to_delete.try_dequeue(key)) {
- db_->Get(options, key, &value);
- decrement_total += value.size();
- batch.Delete(key);
- logger_->log_debug("Removing %s", key);
- }
- }
- if (db_->Write(rocksdb::WriteOptions(), &batch).ok()) {
- logger_->log_debug("Decrementing %u from a repo size of %u",
decrement_total, repo_size_.load());
- if (decrement_total > repo_size_.load()) {
- repo_size_ = 0;
- } else {
- repo_size_ -= decrement_total;
- }
- }
+void ProvenanceRepository::printStats() {
+ logger_->log_info("ProvenanceRepository stats:");
+
+ std::string out;
+ db_->GetProperty("rocksdb.estimate-num-keys", &out);
+ logger_->log_info("\\--Estimated key count: %s", out);
+
+ db_->GetProperty("rocksdb.estimate-table-readers-mem", &out);
+ logger_->log_info("\\--Estimated table readers memory consumption: %s", out);
+
+ db_->GetProperty("rocksdb.cur-size-all-mem-tables", &out);
+ logger_->log_info("\\--Size of all memory tables: %s", out);
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
