arpadboda commented on issue #716: MINIFICPP-1127 - Provenance repo performance should be improved URL: https://github.com/apache/nifi-minifi-cpp/pull/716#issuecomment-582022406 > > > It would be prudent to have some tests for at least the cleanup behaviour of the ProvenanceRepository, and it shouldn't be too hard to create. > > > Please also see my inline comment. > > > > > > If you provide a reasonable time to wait for after inserting the records to make ensure rocksdb background tasks completed the cleanup I'm happy to do so. :) > > Although the "3 secs should be good" approach is not something I would follow, that's the best way to introduce unstable tests. > > I would wait in a loop with some delay, until it is cleaned up. If it takes too long, I would look into tweaking those background task times. If we have the chance - and now we have the chance - we shouldn't replace one untested, broken implementation with an another untested implementation that may be broken or could be broken later because we have no tests for it. Added tests, let's hope these are going to be stable on our CI as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
