jfrazee commented on issue #4012: NIFI-7055 createListValidator should treat 
"," as invalid
URL: https://github.com/apache/nifi/pull/4012#issuecomment-582626469
 
 
   @ottobackwards If I read the JIRA correctly " , " is supposed to stay valid 
for this PR, is that right? If that's the case then LGTM +1
   
   I read through every use of it in the framework to see what the impact would 
be. The only uses of the validator in the framework have trimEntries and 
excludeEmptyEntries set to true. And most uses (CaptureChangeMySQL, 
LivySessionController, DBCPConnectionPool, 
AbstractAzureLogAnalyticsReportingTask/AzureLogAnalyticsReportingTask) 
re-validate or re-split and re-validate before using the value.
   
   Only JMSConnectionFactoryProvider and JndiJmsConnectionFactoryProvider don't 
re-validate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to