alopresto commented on issue #4040: NIFI-6927 Fixes SSL socket factory for ES on JDK9 URL: https://github.com/apache/nifi/pull/4040#issuecomment-583075052 It looks like we have similar/identical code for constructing these objects in [`OkHttpReplicationClient`](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/okhttp/OkHttpReplicationClient.java#L357) and [`InvokeHttp`](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java#L692) among others. I think as this is becoming a common need, we should provide a utility method to wrap this logic and provide it in a class like [`KeyStoreUtils`](https://github.com/apache/nifi/blob/master/nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java#L33) in `nifi-security-utils` module.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
