szaszm commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r376449122
########## File path: libminifi/include/io/ClientSocket.h ########## @@ -20,10 +20,19 @@ #include <cstdint> +#ifdef WIN32 +#ifndef WIN32_LEAN_AND_MEAN +#define WIN32_LEAN_AND_MEAN +#endif +#include <Windows.h> +#include <WS2tcpip.h> +#pragma comment(lib, "Ws2_32.lib") Review comment: I'll try to minimize the includes on windows and see if the `#pragma` is necessary after I've verified that my rebase doesn't break tests on Windows. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
