mattyb149 commented on a change in pull request #4043: NIFI-7109 Unit tests should be able to determine if item validator wa… URL: https://github.com/apache/nifi/pull/4043#discussion_r377231174
########## File path: nifi-commons/nifi-utils/src/test/java/org/apache/nifi/util/validator/TestMockValidator.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.util.validator; + +import org.apache.nifi.components.ValidationContext; +import org.apache.nifi.components.ValidationResult; +import org.apache.nifi.components.Validator; + +/** + * TestMockValidator wraps a {@class Validator} and provides statistics on it's interactions. + * Because many of the {@class Validator} instances returned from {@class StandardValidator } + * are not mockable with with mockito, this is required to know, when running a test, if a + * {@class Validator} was in fact called, for example. + */ +public class TestMockValidator implements Validator { Review comment: Do you think this would be useful in general for unit tests? If so perhaps it should be in the `nifi-mock` module rather than the test sources for `nifi-utils`? I'm fine either way, but this looks like it could be useful in other places, especially things like unit tests for scripted components. I realize nifi-mock brings in nifi-utils, but I don't think it will bring in test artifacts, so wanted to know your thoughts for the best location. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
