szaszm commented on a change in pull request #713: MINIFICPP-1119
MINIFICPP-1154 unify win/posix sockets + fix bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377663356
##########
File path: libminifi/include/io/ClientSocket.h
##########
@@ -93,7 +109,7 @@ class Socket : public BaseStream {
*/
virtual int16_t initialize();
- virtual void setInterface(io::NetworkInterface &&interface) {
+ virtual void setInterface(io::NetworkInterface interface) noexcept {
Review comment:
Removed `noexcept`, marking this discussion as resolved. For my arguments on
`noexcept`, refer to the thread about
`NetworkInterface::operator=(NetworkInterface &&other)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
