szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r378788038
########## File path: extensions/sql/data/WriteCallback.h ########## @@ -0,0 +1,47 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include "FlowFileRecord.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { + +class WriteCallback : public OutputStreamCallback { +public: + WriteCallback(const char *data, uint64_t size) + : _data(const_cast<char*>(data)), Review comment: In that case I'd prefer to have the `const_cast` near the problematic `.data()` call so that it can be deferred from the context that the reason for casting away const is the missing non-`const` `string::data` overload. Alternatively you can pass `&out[0]` if `out.size() > 0`. I'm asking for the workaround to be moved closer to the problem it works around so that we can avoid affecting the interface of unrelated code (`WriteCallback` in this case). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
