alopresto commented on a change in pull request #4062: NIFI-7030 Add Kerberos
principal and password properties to Solr proc…
URL: https://github.com/apache/nifi/pull/4062#discussion_r381675566
##########
File path:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
##########
@@ -149,6 +151,25 @@
.required(false)
.build();
+ public static final PropertyDescriptor KERBEROS_PRINCIPAL = new
PropertyDescriptor.Builder()
+ .name("Kerberos Principal")
+ .description("The principal to use when specifying the principal
and password directly in the processor for authenticating to Solr via
Kerberos.")
+ .required(false)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.addValidator(StandardValidators.createAttributeExpressionLanguageValidator(AttributeExpression.ResultType.STRING))
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+ .build();
+
+ public static final PropertyDescriptor KERBEROS_PASSWORD = new
PropertyDescriptor.Builder()
+ .name("Kerberos Password")
Review comment:
Minor issue but I would use `.name("kerberos-password")` and
`.displayName("Kerberos Password")` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
