[
https://issues.apache.org/jira/browse/MINIFICPP-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040887#comment-17040887
]
Marton Szasz commented on MINIFICPP-1036:
-----------------------------------------
Is this affected by/still valid after your recently merged third party
refactorings, [~bakaid] ?
I think it was this one: [[MINIFICPP-1022] Review passing shipped versions of
libraries to other third parties
(ExternalProjects)|https://issues.apache.org/jira/projects/MINIFICPP/issues/MINIFICPP-1022]
> Review libarchive compilation
> -----------------------------
>
> Key: MINIFICPP-1036
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1036
> Project: Apache NiFi MiNiFi C++
> Issue Type: Task
> Reporter: Dániel Bakai
> Priority: Major
>
> libarchive automatically decides whether to use libz, libbz2 and liblzma
> based on the build host, and then dynamically links with the ones it found.
> This means that we don't have propert control over what libraries we end up
> linking with (unless we have complete control over the build host), and it
> makes it hard to convert libarchive to an ExternalProject. It also prevents
> proper Windows build.
> Because we almost always build zlib as it is, and neither libbz2 nor liblzma
> takes too long to build, I suggest that we bundle them. This would make
> hard-to-control dynamic depenencies go away, and make it easier to have
> complete libarchive support on Windows.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
