szaszm commented on a change in pull request #735: WIP: MINIFICPP-1158 - Event
driven processors can starve each other
URL: https://github.com/apache/nifi-minifi-cpp/pull/735#discussion_r381406703
##########
File path: libminifi/src/CronDrivenSchedulingAgent.cpp
##########
@@ -32,7 +32,7 @@ namespace apache {
namespace nifi {
namespace minifi {
-uint64_t CronDrivenSchedulingAgent::run(const std::shared_ptr<core::Processor>
&processor, const std::shared_ptr<core::ProcessContext> &processContext,
+utils::ComplexResult CronDrivenSchedulingAgent::run(const
std::shared_ptr<core::Processor> &processor, const
std::shared_ptr<core::ProcessContext> &processContext,
const
std::shared_ptr<core::ProcessSessionFactory> &sessionFactory) {
if (this->running_ && processor->isRunning()) {
std::chrono::system_clock::time_point leap_nanos;
Review comment:
A find and replace of `system_clock` to `steady_clock` would make the code
more stable. I see that all changed code is correct, but it would be nice to do
at least the easy fixes on the old broken code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
