am-c-p-p commented on a change in pull request #741: MINIFICPP-1139 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/741#discussion_r383485294
##########
File path: extensions/windows-event-log/Bookmark.cpp
##########
@@ -205,7 +206,7 @@ bool Bookmark::getBookmarkXmlFromFile(std::wstring&
bookmarkXml) {
// '!' should be at the end of bookmark.
auto pos = bookmarkXml.find(L'!');
if (std::wstring::npos == pos) {
- logger_->log_error("No '!' in bookmarXml '%s'", bookmarkXml.c_str());
+ logger_->log_error("No '!' in bookmarXml '%ws'", bookmarkXml.c_str());
Review comment:
According to
https://devblogs.microsoft.com/oldnewthing/20190830-00/?p=102823 it works in
Windows. I'll change to comply with `C standard`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
