mattyb149 commented on a change in pull request #4052: NIFI-7139 Add 
record.error.message on failure of a record reader or w…
URL: https://github.com/apache/nifi/pull/4052#discussion_r383989517
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestConvertRecord.java
 ##########
 @@ -146,12 +145,12 @@ public void testReadFailure() throws 
InitializationException {
         // Original FlowFile should be routed to 'failure' relationship 
without modification
         runner.assertAllFlowFilesTransferred(ConvertRecord.REL_FAILURE, 1);
         final MockFlowFile out = 
runner.getFlowFilesForRelationship(ConvertRecord.REL_FAILURE).get(0);
-        assertTrue(original == out);
+        out.assertContentEquals(original.toByteArray());
 
 Review comment:
   These failures are intentional and so they have a known error message, can 
you add an assert here to verify you got the attribute set as expected?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to