pvillard31 commented on a change in pull request #3879: NIFI-6856 - Support 
MQTT consumer groups
URL: https://github.com/apache/nifi/pull/3879#discussion_r384613985
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
 ##########
 @@ -125,6 +126,7 @@ public ValidationResult validate(String subject, String 
input, ValidationContext
             .name("Client ID")
             .description("MQTT client ID to use. If not set, a UUID will be 
generated.")
             .required(false)
+            
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
 
 Review comment:
   ```suggestion
               
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
   ```
   
   Since the evaluation is done in ``onScheduled``, there is no flow file 
available and we're not using the attributes to make the expression language 
evaluation. You can change the scope to use the Variable Registry.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to