Xeinn opened a new pull request #4104: NIFI-7159 URL: https://github.com/apache/nifi/pull/4104 Aligning the implementation of DECIMAL RecordFieldType with other types Introduce RecordFieldType of DECIMAL for BigDecimal values Adding RecordFieldType DECIMAL to ResultSetRecordSet Introduce RecordFieldType DECIMAL into DataTypeUtils Added missing BIGINT type to convertSimpleIfPossible method Added missing type BIGINT to convertField method Added missing type BIGINT to writeFieldForType Added missing type BIGINT to parseFieldForType Added missing type BIGINT to parseStringForType Potentially breaking change of behaviour for Kudu Service. Switched decimal from treatment as string to treatment as decimal Added big decimal support for ElasticSearch Added big decimal support for hbase processors Added big decimal support for prometheus reporting Added big decimal support to solr Big decimal support in site to site reporting Core support for big decimal Fix issue with new toBigDecimal method Issue where method was not correctly handling the situation where a BigDecimal values was received as input. Update test to reflect use of BigDecimal Changes to unit tests to support DECIMAL type Fix bug where NaN Double reported from jvm metrics not handled BigDecimal implementation for mongo processor Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: #### Description of PR _Enables X functionality; fixes bug NIFI-7159._ In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [Y] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [Y] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [Y] Has your PR been rebased against the latest commit within the target branch (typically `master`)? - [Y] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [Y] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [Y] Have you written or updated unit tests to verify your changes? - [Y] Have you verified that the full build is successful on both JDK 8 and JDK 11? - [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [N/A] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [N/A] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [N/A] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [N/A] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
