m-hogue commented on a change in pull request #4105: NIFI-5925: Added
controller services to set of components that are searched
URL: https://github.com/apache/nifi/pull/4105#discussion_r386706840
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerSearchService.java
##########
@@ -175,13 +176,67 @@ public void search(final SearchResultsDTO results, final
String search, final Pr
}
}
Review comment:
Only question i have for the reviewer is if the `getControllerServices()`
call here should be recursive. I elected to not make it recursive since we're
recursing through `ProcessGroups`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
