tpalfy commented on a change in pull request #4110: NIFI-7226: Add Connection
Factory configuration properties to Publish…
URL: https://github.com/apache/nifi/pull/4110#discussion_r388304494
##########
File path:
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/test/java/org/apache/nifi/jms/cf/JMSConnectionFactoryProviderTest.java
##########
@@ -298,13 +303,13 @@ public void
propertiesSetOnSingleTestBrokerConnectionFactory() throws Initializa
JMSConnectionFactoryProviderForTest cfProvider = new
JMSConnectionFactoryProviderForTest();
runner.addControllerService(controllerServiceId, cfProvider);
- runner.setProperty(cfProvider,
JMSConnectionFactoryProvider.BROKER_URI, SINGLE_TEST_BROKER);
- runner.setProperty(cfProvider,
JMSConnectionFactoryProvider.CLIENT_LIB_DIR_PATH, dummyResource);
- runner.setProperty(cfProvider,
JMSConnectionFactoryProvider.CONNECTION_FACTORY_IMPL,
TEST_CONNECTION_FACTORY_IMPL);
+ runner.setProperty(cfProvider,
JMSConnectionFactoryProperties.JMS_BROKER_URI, SINGLE_TEST_BROKER);
+ runner.setProperty(cfProvider,
JMSConnectionFactoryProperties.JMS_CLIENT_LIBRARIES, dummyResource);
+ runner.setProperty(cfProvider,
JMSConnectionFactoryProperties.JMS_CONNECTION_FACTORY_IMPL,
TEST_CONNECTION_FACTORY_IMPL);
runner.enableControllerService(cfProvider);
- assertEquals(cfProvider.getSetProperties(),
ImmutableMap.of("hostName", HOSTNAME, "port", PORT));
+ assertEquals(cfProvider.getDelegate().getSetProperties(),
ImmutableMap.of("hostName", HOSTNAME, "port", PORT));
Review comment:
No need to leak the `delegate` detail here, we could add a
```java
public Map<String, Object> getSetProperties() {
return ((JMSConnectionFactoryDelegateForTest)
delegate).getSetProperties();
}
```
in `JMSConnectionFactoryProviderForTest`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
