pvillard31 opened a new pull request #4127: NIFI-4970 - Add a property to deal with empty GZIP HTTP response URL: https://github.com/apache/nifi/pull/4127 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: #### Description of PR The initial issue is that when the server's response is indicating **Content-Encoding** as **GZIP** but with no content, we hit an EOF Exception (see [NIFI-4970](https://issues.apache.org/jira/browse/NIFI-4970)). The [first PR #4109](https://github.com/apache/nifi/pull/4109) added a unit test to reproduce the issue and a potential way of dealing with the issue by checking ``responseBody.contentLength() > 0``. The problem is that ``responseBody.contentLength()`` will always be equal to ``-1`` when the server returns a GZIP (with or without actual content) and we're going to ignore the response in case there is content to process. This PR reverts the check but adds a property to let the user decides wether content is expected or not. In case it is expected to have no content from the server, this will be ignored and no exception will be generated. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
