simonbence commented on a change in pull request #4123: NIFI-7188: Adding
filter capabilities into search & prerequisite refactors
URL: https://github.com/apache/nifi/pull/4123#discussion_r390859318
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
##########
@@ -147,8 +148,8 @@
// properties
private NiFiProperties properties;
private DtoFactory dtoFactory;
- private VariableRegistry variableRegistry;
private ControllerSearchService controllerSearchService;
+ private SearchQueryParser searchQueryParser;
Review comment:
It is a user input parser, and based on that I think it is belongs more to
the controller side than the service side. I think it is more clear from the
perspective of boundaries if the service is not responsible to parse the user
input string but working with a request object. Also from the practical side:
as the "search" and the "searchParameters" are called separately from the
controller facade and they both need the user input, it looks unnecessary to
parse it twice within the search methods. (This separation that they are
distinct calls is a decision from the original code which I did not intend to
change)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
