mcgilman commented on a change in pull request #4123: NIFI-7188: Adding filter
capabilities into search & prerequisite refactors
URL: https://github.com/apache/nifi/pull/4123#discussion_r392525507
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
##########
@@ -1614,15 +1615,20 @@ private void setComponentDetails(final
ProvenanceEventDTO dto) {
/**
* Searches this controller for the specified term.
*
- * @param search search
+ * @param searchLiteral search
+ * @param activeGroupId the identifier of the currently visited group
* @return result
*/
- public SearchResultsDTO search(final String search) {
+ public SearchResultsDTO search(final String searchLiteral, final String
activeGroupId) {
final ProcessGroup rootGroup = getRootGroup();
+ final ProcessGroup activeGroup =
flowController.getFlowManager().getGroup(activeGroupId);
Review comment:
`getGroup` here requires non null. While the update to our primary client
(the UI) has been updated to always include the active group other clients
(like scripts or CLIs) may not be including the new parameter. If the
`activeGroupId` is null I would recommend using the root group which should
maintain existing functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
