bakaid commented on a change in pull request #713: MINIFICPP-1119
MINIFICPP-1154 unify win/posix sockets + fix bugs
URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r392895813
##########
File path: libminifi/include/io/BaseStream.h
##########
@@ -175,13 +174,12 @@ class BaseStream : public DataStream, public
Serializable {
**/
virtual int read(uint64_t &value, bool is_little_endian =
EndiannessCheck::IS_LITTLE);
- virtual const uint64_t getSize() const {
+ const uint64_t getSize() const override {
Review comment:
Selectively introducing `override` results in a bunch of
inconsistent-missing-override warnings, like these:
```
In file included from
/Users/danielbakai/nifi-minifi-cpp4/extensions/http-curl/tests/HttpPostIntegrationTest.cpp:31:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/utils/HTTPClient.h:21:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/utils/ByteArrayCallback.h:21:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/FlowFileRecord.h:32:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/core/ContentRepository.h:22:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/ResourceClaim.h:31:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/core/StreamManager.h:24:
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/io/BaseStream.h:134:15:
warning: 'readData' overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
virtual int readData(uint8_t *buf, int buflen);
^
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/io/DataStream.h:72:15:
note: overridden virtual function is here
virtual int readData(uint8_t *buf, int buflen);
^
In file included from
/Users/danielbakai/nifi-minifi-cpp4/extensions/http-curl/tests/HttpPostIntegrationTest.cpp:31:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/utils/HTTPClient.h:21:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/utils/ByteArrayCallback.h:21:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/FlowFileRecord.h:32:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/core/ContentRepository.h:22:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/ResourceClaim.h:31:
In file included from
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/core/StreamManager.h:24:
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/io/BaseStream.h:142:15:
warning: 'read' overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
virtual int read(uint16_t &base_value, bool is_little_endian =
EndiannessCheck::IS_LITTLE);
^
/Users/danielbakai/nifi-minifi-cpp4/libminifi/include/io/DataStream.h:97:15:
note: overridden virtual function is here
virtual int read(uint16_t &value, bool is_little_endian =
EndiannessCheck::IS_LITTLE);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
