bakaid commented on issue #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#issuecomment-599608120 @szaszm @arpadboda Ran RAW socket tests with a secure instance of NiFi (thereby testing TLSSocket), both on macOS and Windows, they seem to work fine. SecureSocketGetTCPTest* tests are failing on Windows however. They work fine on macOS, but on a Windows 10 they exit/crash/throw unhandled exceptions after the ``` [2020-03-16 15:38:19.880] [org::apache::nifi::minifi::io::TLSSocket] [debug] Successfully applied O_NONBLOCK to fd ``` line is logged. Also, Travis CI macOS builds fail, because the newly introduced inconsistent-missing-override warnings make them go over the maximum log length limit. With this fact my comment about the warnings is no longer advisory, as it prevents successful CI runs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
