arpadboda commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r393371562
########## File path: extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.h ########## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef __UNORDERED_MAP_PERSISTABLE_KEY_VALUE_STORE_SERVICE_H__ +#define __UNORDERED_MAP_PERSISTABLE_KEY_VALUE_STORE_SERVICE_H__ + +#include "controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h" +#include "UnorderedMapKeyValueStoreService.h" +#include "core/Core.h" +#include "properties/Configure.h" +#include "core/logging/Logger.h" +#include "core/logging/LoggerConfiguration.h" +#include "core/Resource.h" + +#include <unordered_map> +#include <string> +#include <mutex> +#include <memory> +#include <utility> + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace controllers { + +class UnorderedMapPersistableKeyValueStoreService : public AbstractAutoPersistingKeyValueStoreService, Review comment: What's the motivation behind these class? The implementation looks good, but I'm not sure if there is any value in having a maintaining a 3rd store service. I wonder if we could utilise a very tiny and simple 3rd party kv storage for this purpose instead of having an own implementation. The non-serialized makes perfect sense for "no footprint" usage, it can be configured together with volatile repos. The rocksdb one allignes perfectly with the rocksdb repos. This one stands somewhere in the middle, to ensure persistency in case of not having rocksdb, although I feel that we introduce a something we will have to support for long and it doesn't really add value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
