shawnweeks commented on a change in pull request #4147: NIFI-7260: Fix error
handling and re-evaluate Module Directory property on changed for scripted
controller services
URL: https://github.com/apache/nifi/pull/4147#discussion_r393620016
##########
File path:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/record/script/AbstractScriptedRecordFactory.java
##########
@@ -42,9 +42,13 @@ public void setup() {
if (scriptNeedsReload.get() || recordFactory.get() == null) {
if
(ScriptingComponentHelper.isFile(scriptingComponentHelper.getScriptPath())) {
- reloadScriptFile(scriptingComponentHelper.getScriptPath());
+ if
(!reloadScriptFile(scriptingComponentHelper.getScriptPath())) {
Review comment:
I'm not sure we need to raise an exception here since reloadScriptFile and
reloadScriptBody already add a validation failure and logs it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
