msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r397589151
########## File path: libminifi/src/c2/C2Agent.cpp ########## @@ -32,24 +32,34 @@ #include "utils/file/FileUtils.h" #include "utils/file/FileManager.h" #include "utils/HTTPClient.h" +#include "utils/GeneralUtils.h" +#include "utils/Monitors.h" + namespace org { namespace apache { namespace nifi { namespace minifi { namespace c2 { -C2Agent::C2Agent(const std::shared_ptr<core::controller::ControllerServiceProvider> &controller, const std::shared_ptr<state::StateMonitor> &updateSink, - const std::shared_ptr<Configure> &configuration) +std::shared_ptr<utils::IdGenerator> C2Agent::id_generator_ = utils::IdGenerator::getIdGenerator(); Review comment: Yep, that remained to be fixed. I forgot to make correction here. There is one more in FlowController.cpp. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services