joewitt commented on issue #4169: NIFI-7338 Adding GetSmbFile and PutSmbFile processors #2 URL: https://github.com/apache/nifi/pull/4169#issuecomment-611089045 I am reviewing this for now. But the level of effort to do so is problematic. First I dont have any SMB file shares enabled so I'm reading how to set that up. The processor docs don't cover any details on the configuration scenarios. workgroup, user and password are all not required. What combination is that good for? What if I only set a workgroup? What if workgroup and user but not password? There should be descriptions of these cases. Have more questions there I think. does this processor set the provenance values correctly? Nar size is 4MB so that is good.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
