apiri commented on issue #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven URL: https://github.com/apache/nifi/pull/4203#issuecomment-612651329 @mattyb149 Changes look good and straightforward here. We should have these mirrored in https://github.com/apache/nifi/blob/master/nifi-docker/dockerhub/sh/start.sh. What would be more correct in the longer term is to structure our Docker images such that we could reuse one copy. Believe I created a ticket at some point to address this but doesn't need to happen within this particular issue as it is certainly more involved. As long as we provide the same configurability for the image we publish to Hub, looks good to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
