tpalfy commented on a change in pull request #4195: NIFI-7292 Preventing file
listing from fail because of insufficient privileges
URL: https://github.com/apache/nifi/pull/4195#discussion_r408103247
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java
##########
@@ -547,31 +549,67 @@ public boolean test(final Path path, final
BasicFileAttributes attributes) {
}
};
- final Stream<Path> inputStream = getPathStream(basePath, maxDepth,
matcher);
+ try {
+ final long start = System.currentTimeMillis();
Review comment:
The current solution is conceptually different than what is written in
https://issues.apache.org/jira/browse/NIFI-7292.
This implementation skips inaccessible directories, even if they are not
being filtered out.
Not necessarily a bad thing, but I think it should be clarified in the Jira
if we want to accept this.
And/or add at least a test case with a PATH_FILTER.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
