szaszm opened a new pull request #754: MINIFICPP-1151 fix most 1st party compiler warnings URL: https://github.com/apache/nifi-minifi-cpp/pull/754 Remaining: - MSVC: multiple warning LNK4221: This object file does not define any previously undefined public symbols, so it will not be used by any link operation that consumes this library - MSVC/expression language: multiple warning C4566: character represented by universal-character-name '\u????' cannot be represented in the current code page (1252) - clang/expression language yacc: warning: fix-its can be applied. Rerun with option '--update'. [-Wother] Squashed commit of the following: commit 98a04a4c83bef712b04fce151d98414a142d6ee4 Author: Marton Szasz <[email protected]> Date: Tue Apr 14 15:00:54 2020 +0200 MINIFICPP-1151 windows (except expression language) commit d58e7342f2c5ebbfa6e4c664666b6f0f81355489 Author: Marton Szasz <[email protected]> Date: Tue Apr 7 10:18:26 2020 +0200 MINIFICPP-1151 linux, clang 10 note: rocksdb compilation correctly fails with clang 10. We will need to upgrade or patch it. commit 995d6f7031947e4fc6e4370a2b04eba998d84ada Author: Marton Szasz <[email protected]> Date: Mon Feb 10 21:35:29 2020 +0100 verified on clang6/linux There are some warnings due to overriding a ROCKSDB_ASSERT macro to throw and it's expanded inside `noexcept` functions. No idea how to fix that. commit b20761da23fde4b108c5bda736c1f14cc822e652 Author: Marton Szasz <[email protected]> Date: Mon Feb 10 18:05:55 2020 +0100 fix compilation errors commit acbebcbbcef05a294e8a7cecb2da8e0202ffb53a Author: Marton Szasz <[email protected]> Date: Mon Feb 10 15:58:05 2020 +0100 MINIFICPP-1151 round #1: GCC 7 on ubuntu, default config Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
