arpadboda commented on a change in pull request #687: MINIFICPP-1092 - Make
CoAP compile and work on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/687#discussion_r408872105
##########
File path: extensions/coap/COAPLoader.h
##########
@@ -28,6 +28,13 @@
#include "utils/StringUtils.h"
#include "protocols/CoapC2Protocol.h"
+class COAPObjectFactoryInitializer : public core::ObjectFactoryInitializer {
+ public:
+ virtual bool initialize();
Review comment:
Could you add override here?
I guess this PR was created before we agreed on using override.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
