turcsanyip commented on a change in pull request #4213: NIFI-7280 Use Atlas
metadata namespace in Atlas Reporting Task
URL: https://github.com/apache/nifi/pull/4213#discussion_r409521875
##########
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##########
@@ -333,30 +339,34 @@
@Override
protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
final List<PropertyDescriptor> properties = new ArrayList<>();
+ // Basic atlas config
properties.add(ATLAS_URLS);
- properties.add(ATLAS_CONNECT_TIMEOUT);
- properties.add(ATLAS_READ_TIMEOUT);
- properties.add(ATLAS_AUTHN_METHOD);
- properties.add(ATLAS_USER);
- properties.add(ATLAS_PASSWORD);
- properties.add(ATLAS_CONF_DIR);
- properties.add(ATLAS_NIFI_URL);
properties.add(ATLAS_DEFAULT_CLUSTER_NAME);
- properties.add(NIFI_LINEAGE_STRATEGY);
- properties.add(PROVENANCE_START_POSITION);
- properties.add(PROVENANCE_BATCH_SIZE);
- properties.add(SSL_CONTEXT_SERVICE);
+ properties.add(ATLAS_CONF_DIR);
+ properties.add(ATLAS_CONF_CREATE);
// Following properties are required if ATLAS_CONF_CREATE is enabled.
// Otherwise should be left blank.
- properties.add(ATLAS_CONF_CREATE);
+ // Will be used by the atlas client by reading the values from the
atlas config file
+ properties.add(ATLAS_CONNECT_TIMEOUT);
+ properties.add(ATLAS_READ_TIMEOUT);
+ properties.add(SSL_CONTEXT_SERVICE);
properties.add(KERBEROS_CREDENTIALS_SERVICE);
properties.add(NIFI_KERBEROS_PRINCIPAL);
properties.add(NIFI_KERBEROS_KEYTAB);
properties.add(KAFKA_KERBEROS_SERVICE_NAME);
properties.add(KAFKA_BOOTSTRAP_SERVERS);
properties.add(KAFKA_SECURITY_PROTOCOL);
+ // General config used by the processor
+ properties.add(NIFI_LINEAGE_STRATEGY);
+ properties.add(PROVENANCE_START_POSITION);
+ properties.add(PROVENANCE_BATCH_SIZE);
+ properties.add(ATLAS_AUTHN_METHOD);
+ properties.add(ATLAS_USER);
+ properties.add(ATLAS_PASSWORD);
Review comment:
The auth parameters are quite important / always need to be set.
I'd suggest moving them up, after the Atlas URL or just before the Kerberos
params.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
