bakaid commented on a change in pull request #605:
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r413746596
##########
File path: extensions/sql/processors/ExecuteSQL.cpp
##########
@@ -81,14 +81,14 @@ void ExecuteSQL::initialize() {
setSupportedRelationships( { s_success });
}
-void ExecuteSQL::processOnSchedule(const core::ProcessContext &context) {
+void ExecuteSQL::processOnSchedule(core::ProcessContext &context) {
initOutputFormat(context);
context.getProperty(s_sqlSelectQuery.getName(), sqlSelectQuery_);
context.getProperty(s_maxRowsPerFlowFile.getName(), max_rows_);
}
-void ExecuteSQL::processOnTrigger(core::ProcessSession &session) {
+void ExecuteSQL::processOnTrigger(core::ProcessContext& /*context*/,
core::ProcessSession& session) {
Review comment:
In a previous iteration QueryDatabaseTables's processOnTrigger needed
the context, so it had to be put on the CRTP interface of SQLProcessor. It has
been rewritten since and it is no longer needed by QDT, so I removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
