szaszm commented on a change in pull request #605:
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r413844725
##########
File path: extensions/windows-event-log/Bookmark.cpp
##########
@@ -222,7 +184,7 @@ bool Bookmark::getBookmarkXmlFromFile(std::wstring&
bookmarkXml) {
if (std::wstring::npos == pos) {
logger_->log_error("No '!' in bookmarXml '%ls'", bookmarkXml.c_str());
bookmarkXml.clear();
- return createEmptyBookmarkXmlFile();
+ return false;
Review comment:
If you find a simple way to disable automatic reformatting in VS, I'm
interested as well. I sometimes have to recreate my windows changes on my linux
editor to avoid huge diffs due to automatic reformatting.
There are a handful of options, but no obvious (to me) way to disable
messing with unchanged code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
