szaszm commented on a change in pull request #754:
URL: https://github.com/apache/nifi-minifi-cpp/pull/754#discussion_r414758120
##########
File path: extensions/http-curl/tests/HttpGetIntegrationTest.cpp
##########
@@ -120,16 +119,16 @@ int main(int argc, char **argv) {
std::shared_ptr<minifi::processors::InvokeHTTP> inv =
std::dynamic_pointer_cast<minifi::processors::InvokeHTTP>(proc);
assert(inv != nullptr);
- std::string url = "";
+ std::string url;
inv->getProperty(minifi::processors::InvokeHTTP::URL.getName(), url);
- ptr.release();
+ ptr = nullptr;
Review comment:
The segfaults are likely related to this line, I'll investigate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
