alopresto commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r416744601
##########
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##########
@@ -271,4 +302,59 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
}
+
+ @OnScheduled
+ public void createClient(ProcessContext context) throws IOException {
Review comment:
I think all 6 of the MongoDB processors need this change if one does, so
it should be made in a consistent manner. It appears the Jira is incomplete as
it only indicates the `GetMongo` processor, but that's what this review process
is intended to mitigate. Requirements gathering is notoriously difficult and a
single user's request has to be balanced against the ongoing needs of the
project as a whole. Any code changes introduced need to be well-understood,
complete, tested, sustainable, and maintainable. I use the analogy from camping
of "leave it better than you found it."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
