sjyang18 commented on a change in pull request #4175:
URL: https://github.com/apache/nifi/pull/4175#discussion_r417699411
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##########
@@ -91,6 +124,15 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
try {
+ if (!userMetadata.isEmpty()) {
+ blob.setMetadata(userMetadata);
+
+ StringBuilder userMetaBldr = new StringBuilder();
+ for (String userKey : userMetadata.keySet()) {
+
userMetaBldr.append(userKey).append("=").append(userMetadata.get(userKey));
+ }
Review comment:
shouldn't we have a delimiter between entries? For example, if we have
these properties:
runner.setProperty("hello", "world");
runner.setProperty("java", "world");
then, azure.usermetadata='java=worldhello=world' when I modify and run your
test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
