[
https://issues.apache.org/jira/browse/MINIFICPP-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dániel Bakai updated MINIFICPP-1055:
------------------------------------
Description:
These can disable functionality if we use clang (Linux alternative or macOS) or
MSVC.
Our problematic __GNUC__ usages fall into the following categories:
Warning disable pragmas:
nanofi/include/sitetosite/CSiteToSite.h
extensions/standard-processors/processors/TailFile.cpp
extensions/standard-processors/processors/ExecuteProcess.cpp
libminifi/test/unit/ProvenanceTestHelper.h
libminifi/include/core/repository/VolatileRepository.h
libminifi/include/sitetosite/SiteToSite.h
It may be beneficial to create common warning disabling macros instead of these
individual ones: https://issues.apache.org/jira/browse/MINIFICPP-1211
Other usages:
libminifi/include/core/yaml/YamlConfiguration.h -> Regex usage
(https://issues.apache.org/jira/browse/MINIFICPP-1212)
extensions/expression-language/impl/expression/Expression.h -> Regex and date
usage (https://issues.apache.org/jira/browse/MINIFICPP-1054)
was:
These can disable functionality if we use clang (Linux alternative or macOS) or
MSVC.
Our problematic __GNUC__ usages fall into the following categories:
Warning disable pragmas:
nanofi/include/sitetosite/CSiteToSite.h
extensions/standard-processors/processors/TailFile.cpp
extensions/standard-processors/processors/ExecuteProcess.cpp
libminifi/test/unit/ProvenanceTestHelper.h
libminifi/include/core/repository/VolatileRepository.h
libminifi/include/sitetosite/SiteToSite.h
It may be beneficial to create common warning disabling macros instead of these
individual ones: https://issues.apache.org/jira/browse/MINIFICPP-1211
Other usages:
libminifi/include/core/yaml/YamlConfiguration.h -> Regex usage
(https://issues.apache.org/jira/browse/MINIFICPP-1212)
extensions/expression-language/impl/expression/Expression.h -> regex date usage
(https://issues.apache.org/jira/browse/MINIFICPP-1054)
> Investigate preprocessor expressions including __GNUC__
> -------------------------------------------------------
>
> Key: MINIFICPP-1055
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1055
> Project: Apache NiFi MiNiFi C++
> Issue Type: Task
> Reporter: Dániel Bakai
> Assignee: Dániel Bakai
> Priority: Major
> Fix For: 0.8.0
>
>
> These can disable functionality if we use clang (Linux alternative or macOS)
> or MSVC.
>
> Our problematic __GNUC__ usages fall into the following categories:
> Warning disable pragmas:
> nanofi/include/sitetosite/CSiteToSite.h
> extensions/standard-processors/processors/TailFile.cpp
> extensions/standard-processors/processors/ExecuteProcess.cpp
> libminifi/test/unit/ProvenanceTestHelper.h
> libminifi/include/core/repository/VolatileRepository.h
> libminifi/include/sitetosite/SiteToSite.h
> It may be beneficial to create common warning disabling macros instead of
> these individual ones: https://issues.apache.org/jira/browse/MINIFICPP-1211
> Other usages:
> libminifi/include/core/yaml/YamlConfiguration.h -> Regex usage
> (https://issues.apache.org/jira/browse/MINIFICPP-1212)
> extensions/expression-language/impl/expression/Expression.h -> Regex and
> date usage (https://issues.apache.org/jira/browse/MINIFICPP-1054)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
