joewitt commented on pull request #4242: URL: https://github.com/apache/nifi/pull/4242#issuecomment-623497483
@james94 We need to be clear/careful here. The word 'open source' is not very helpful in this case. License Compatibility: The ASF publishes clear guidelines for what is acceptable to include. It is detailed relative to NiFi concerns here http://nifi.apache.org/licensing-guide.html. I don't know which open source license you're referring to for 'h2o-3' - please clarify. Further, it is not clear to me whether you're saying "we could close this PR and make a new one that uses that" or whether this PR works with that. Maintainability by the community: We don't know h2o. So even understanding some of what you're talking about and options available here is unclear. What happens in a few months if you're not helping maintain this and we need a committer to do so and there is a CVE or something we need to update. We've learned this lesson the hard way. For the above reasons I think you should just avoid putting these h2o specific items into apache at all. Instead I think h2o should publish their nifi-h2o-nar and just tell us about it. We can help people learn it exists without having to maintain any code or deal with the unique licensing/usability concerns here. To be clear this stuff is cool. I hope folks can use it. I just dont want to sign up to spend time learning and parsing the above. This PR as-is I believe should be closed unless I'm missing something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
