msharee9 commented on a change in pull request #775:
URL: https://github.com/apache/nifi-minifi-cpp/pull/775#discussion_r419491795
##########
File path: extensions/http-curl/client/HTTPClient.h
##########
@@ -124,11 +135,11 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable {
bool setMinimumSSLVersion(SSLVersion minimum_version) override;
- void setKeepAliveProbe(long probe){
+ void setKeepAliveProbe(std::chrono::milliseconds probe){
keep_alive_probe_ = probe;
}
- void setKeepAliveIdle(long idle){
Review comment:
Agree. especially when they are public members.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
