jfrazee commented on a change in pull request #4253: URL: https://github.com/apache/nifi/pull/4253#discussion_r420989837
########## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/services/azure/cosmos/document/AzureCosmosDBConnectionControllerService.java ########## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.nifi.services.azure.cosmos.document; + +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; + +import org.apache.nifi.annotation.lifecycle.OnEnabled; +import org.apache.nifi.annotation.lifecycle.OnStopped; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.ValidationContext; +import org.apache.nifi.components.ValidationResult; +import org.apache.nifi.controller.AbstractControllerService; +import org.apache.nifi.controller.ConfigurationContext; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.services.azure.cosmos.AzureCosmosDBConnectionService; +import org.apache.nifi.util.StringUtils; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; + +import com.azure.cosmos.ConnectionPolicy; +import com.azure.cosmos.ConsistencyLevel; +import com.azure.cosmos.CosmosClient; +import com.azure.cosmos.CosmosClientBuilder; + +@Tags({"azure", "cosmos", "document", "service"}) +@CapabilityDescription( + "Provides a controller service that configures a connection to Azure Cosmos DB (Document API or Core SQL API recently renamed) " + + " and provides access to that connection to other AzureCosmosDB-related components." +) +public class AzureCosmosDBConnectionControllerService extends AbstractControllerService implements AzureCosmosDBConnectionService { + static final String CONSISTENCY_STRONG = "STRONG"; + static final String CONSISTENCY_BOUNDED_STALENESS= "BOUNDED_STALENESS"; + static final String CONSISTENCY_SESSION = "SESSION"; + static final String CONSISTENCY_CONSISTENT_PREFIX = "CONSISTENT_PREFIX"; + static final String CONSISTENCY_EVENTUAL = "EVENTUAL"; + private String uri; + private String accessKey; + protected CosmosClient cosmosClient; + + public static final PropertyDescriptor URI = new PropertyDescriptor.Builder() + .name("azure-cosmos-db-uri") + .displayName("Azure Cosmos DB URI") + .description("CosmosURI, typically of the form: https://{databaseaccount}.documents.azure.com:443/. Note this URI is for Azure Cosmos DB with SQL API") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .build(); + + public static final PropertyDescriptor DB_ACCESS_KEY = new PropertyDescriptor.Builder() + .name("azure-cosmos-db-key") + .displayName("Azure Cosmos DB Access Key") + .description("Azure Cosmos DB Access Key from Azure Portal (Settings->Keys)") + .required(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .sensitive(true) + .build(); + + public static final PropertyDescriptor CONSISTENCY = new PropertyDescriptor.Builder() + .name("azure-cosmos-consistency-level") + .displayName("Azure Cosmos DB Consistency Level") + .description("Azure Cosmos DB Consistency Level to use") + .required(false) + .allowableValues(CONSISTENCY_STRONG, CONSISTENCY_BOUNDED_STALENESS, CONSISTENCY_SESSION, + CONSISTENCY_CONSISTENT_PREFIX, CONSISTENCY_EVENTUAL) + .defaultValue(CONSISTENCY_SESSION) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .build(); + + @OnEnabled + public void onEnabled(final ConfigurationContext context) { + this.uri = context.getProperty(URI).getValue(); + this.accessKey = context.getProperty(DB_ACCESS_KEY).getValue(); + final ConsistencyLevel clevel; + final String selectedConsistency = context.getProperty(CONSISTENCY).getValue(); + + switch(selectedConsistency) { + case CONSISTENCY_STRONG: + clevel = ConsistencyLevel.STRONG; + break; + case CONSISTENCY_CONSISTENT_PREFIX: + clevel = ConsistencyLevel.CONSISTENT_PREFIX; + break; + case CONSISTENCY_SESSION: + clevel = ConsistencyLevel.SESSION; + break; + case CONSISTENCY_BOUNDED_STALENESS: + clevel = ConsistencyLevel.BOUNDED_STALENESS; + break; + case CONSISTENCY_EVENTUAL: + clevel = ConsistencyLevel.EVENTUAL; + break; + default: + clevel = ConsistencyLevel.SESSION; + } + + if (cosmosClient != null) { + closeClient(); + } + createCosmosClient(uri, accessKey, clevel); + } + + + @OnStopped + public final void closeClient() { + if (this.cosmosClient != null) { + cosmosClient.close(); Review comment: Does this ever throw any exceptions? If so then I think it should get wrapped in a try-catch ignore so `cosmosClient = null` definitely happens. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
