jfrazee commented on a change in pull request #4164:
URL: https://github.com/apache/nifi/pull/4164#discussion_r422196412
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/sensitive/SensitivePropertyProvider.java
##########
@@ -14,10 +14,20 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.nifi.properties;
+package org.apache.nifi.properties.sensitive;
Review comment:
I agree that the package layout is clearer (esp. in the context of the
other work). And I'm skeptical that this would have been an extension point
previously since you'd have to have changed other parts of the codebase, but
nonetheless they're public. What are your thoughts on leaving the old stuff in
place and deprecating them for a few releases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]