bbende commented on a change in pull request #276:
URL: https://github.com/apache/nifi-registry/pull/276#discussion_r426019562
##########
File path:
nifi-registry-core/nifi-registry-web-ui/src/main/webapp/nf-registry.html
##########
@@ -74,7 +74,7 @@
<div *ngIf="nfRegistryService.currentUser.identity &&
nfRegistryService.perspective !== 'login' && nfRegistryService.perspective !==
'not-found'" fxLayout="column" fxLayoutAlign="space-around end"
class="push-right-sm">
<div id="current-user"
matTooltip="{{nfRegistryService.currentUser.identity}}">{{nfRegistryService.currentUser.identity}}</div>
<a id="logout-link-container"
*ngIf="nfRegistryService.currentUser.canLogout" class="link"
(click)="logout()">logout</a>
- <a id="logout-link-container"
*ngIf="!nfRegistryService.currentUser.canLogout &&
nfRegistryService.currentUser.anonymous &&
nfRegistryService.currentUser.loginSupported" class="link"
(click)="login()">login</a>
+ <a id="login-link-container"
*ngIf="!nfRegistryService.currentUser.canLogout &&
nfRegistryService.currentUser.anonymous &&
nfRegistryService.currentUser.loginSupported" class="link"
(click)="login()">login</a>
Review comment:
yes it was just something I noticed that we shouldn't be using the same
id for two different links, probably should have been a separate PR but it was
only 2 changes lines so I included it here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
