phrocker commented on pull request #781: URL: https://github.com/apache/nifi-minifi-cpp/pull/781#issuecomment-630321686
> I have a concern regarding the contribution of these processors. Myself and probably most minifi c++ contributors are unfamiliar with H2O, which makes it problematic to maintain the new processors. > > The first problem I ran into while reviewing #784 is that I couldn't easily verify whether those changes would break these new processors. > > This problem (and others) could be mostly solved if you could submit integration tests covering these processors. Could you do that? It took me a while to get around to testing this. My hope on the original merge would be that I would create a ticket and create a test for this, but I'm coming around to the fact that I'm too busy to do such things. I agree with what @szaszm is saying, especially in regards to having regression tests that would make this easier to merge. I think this solves the licensing issue; however, some tests would be super useful if possible. pytest-mock would be a useful testing framework to explore and should make this a pretty low water mark to solve this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
