sjyang18 commented on a change in pull request #4265:
URL: https://github.com/apache/nifi/pull/4265#discussion_r426906518
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java
##########
@@ -85,6 +85,22 @@
.sensitive(true)
.build();
+ public static final PropertyDescriptor ENDPOINT_SUFFIX = new
PropertyDescriptor.Builder()
+ .name("storage-endpoint-suffix")
+ .displayName("Storage Endpoint Suffix")
+ .description(
+ "Storage accounts in public Azure always use a common FQDN
suffix. " +
+ "Override this endpoint suffix with a different suffix in
certain circumsances (like Azure Stack or non-public Azure regions). " +
+ "The preferred way is to configure them through a
controller service specified in the Storage Credentials property. " +
+ "The controller service can provide a common/shared
configuration for multiple/all Azure processors. Furthermore, the credentials "
+
+ "can also be looked up dynamically with the 'Lookup'
version of the service.")
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
Review comment:
This PR addresses the need to support Azure Stack and Azure Gov cloud.
This PR binds to
CloudStorageAccount.CloudStorageAccount(
final StorageCredentials storageCredentials, final boolean
useHttps, final String endpointSuffix, String accountName)
API, which has equivalent common pattern and endpoint suffix support in both
Datalake SDK and Storage SDK.
While, to bind the development environment, I see different SDK API.
CloudStorageAccount.getDevelopmentStorageAccount(final URI proxyUri)
, which uses the fixed DEVSTORE_ACCOUNT_NAME and DEVSTORE_ACCOUNT_KEY.
private static final String DEVSTORE_ACCOUNT_KEY =
"Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==";
private static final String DEVSTORE_ACCOUNT_NAME = "devstoreaccount1";
This means that you don't even need to set account name and key to bind to
the development environment.
@esecules and @jfrazee ,
How critical is it to address NIFI-7386 in this PR? We could address the
problem with 'development-environment-uri', rather than endpoint-suffix.
And, using one property for endpoint_suffix in one case and for endpoint URI
in another case will make it confusing, in my opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
